ArraySet needs refactoring #9

New Issue

2021-01-27T06:03:58+01:00

Speiger commented

2021-01-27 06:03:58 +01:00

The ArraySet implementation isn't as optimal as it should be. It passes the tests and works fine otherwise, but some functions do not return expected results, though these are usually less used implementations. (SubSet/HeadSet/TailSet)

A whole refactor of that class has to be made to fix foundation issues with the implementation and to setup a rulesheet how a implementation should work.

Known issues:

SubSet size could be 1 element larger then expected.
ToArray could be a array copy implementation instead of the default AbstractImplementation.
SubSet toArray implementation only copies half of the elements and the other half is not included.

The ArraySet implementation isn't as optimal as it should be. It passes the tests and works fine otherwise, but some functions do not return expected results, though these are usually less used implementations. (SubSet/HeadSet/TailSet) A whole refactor of that class has to be made to fix foundation issues with the implementation and to setup a rulesheet how a implementation should work. Known issues: - [x] SubSet size could be 1 element larger then expected. - [x] ToArray could be a array copy implementation instead of the default AbstractImplementation. - [x] SubSet toArray implementation only copies half of the elements and the other half is not included.

Speiger added the bug enhancement labels 2021-01-27 06:03:58 +01:00

Speiger added this to the 1.0.0 Release milestone 2021-01-27 06:06:10 +01:00

Speiger closed this issue

2021-05-28 20:07:23 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Speiger/Primitive-Collections#9